Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6739 Display moderated commenting notice on individual chapters #4859

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

sarken
Copy link
Collaborator

@sarken sarken commented Jun 18, 2024

Issue

https://otwarchive.atlassian.net/browse/AO3-6739

Purpose

If you accessed at a work with moderated commenting enabled in chapter-by-chapter mode, it said "Chapter" (the i18n key, which was wrong -- there's not a dedicated notice for chapters) instead of "This work's creator has chosen to moderate comments on the work. Your comment will not appear until it has been approved by the creator."

Now it uses the right key and says the big long thing.

Testing Instructions

Refer to Jira.

References

#4790

@Bilka2
Copy link
Contributor

Bilka2 commented Jun 18, 2024

Are the other spots that use commentable.model_name.i18n_key all fine or can they also be per chapter?

<p class="note"><%= t(".note.#{@commentable.model_name.i18n_key}") %></p>
t("comments.create.success.moderated.#{@comment.ultimate_parent.model_name.i18n_key}")

@sarken
Copy link
Collaborator Author

sarken commented Jun 19, 2024

It looks like they're fine. There's no unreviewed comments page for individual chapters (it 404s if you do, e.g., https://test.archiveofourown.org/works/1089709/chapters/2182327/comments/unreviewed) and the ultimate_parent is always either a work, admin post, or tag (I initially wanted to use ultimate_parent.model_name.i18n_key for this, but that didn't work quite as nicely as I'd hoped).

@brianjaustin brianjaustin merged commit 325f5de into otwcode:master Jun 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants