AO3-6548 Use pseud helpers in comment emails and fix kudos image display

[EchoEkhi]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6548

Purpose

Fix email style in AO3-6548

Testing Instructions

See JIRA ticket

Credit

EchoEkhi (He/him)

[Bilka2]

Small note: This sets the red color on both the <b> tag and the <a> tag. But I don't think this matters, batch_subscription_notification.html.erb does it too. If it does matter then this could use tag.strong instead of style_bold.

[Bilka2]

Suggested change

	background: url("/images/imageset.png") no-repeat -111px -580px;
	width: 55px;
	height: 54px;
	background: url("/images/imageset.png") no-repeat -110px -580px;
	width: 55px;
	height: 55px;

This matches more what is in the png.

[EchoEkhi]

It shows a bit of the adjacent images when viewed in Firefox if I change it to round numbers. Works fine on chrome though.

[Bilka2]

I can confirm that the ::before trick fixes the kudos image display. However, it's now positioned lower than before.
This PR on the left, staging in the middle and production on the right:

Furthermore, the text flows differently if it's long (= many kudos by users):

I don't know whether that's okay. Also, the min-height change in #4686 moved the comment box up (visible in staging + dev in the first screenshot). Again, no idea if that is okay. But leaving my screenshots here in case it helps someone else review.

[brianjaustin]

@sarken pointed out to me that we have a helper that can help here:

otwarchive/app/helpers/mailer_helper.rb

Lines 37 to 44 in 93184ce

	def style_pseud_link(pseud)
	style_link("<img src=\"" + root_url + "favicon.ico\" style=\"border:none;display:inline-block;font-weight:bold;height:16px;padding-right:3px;vertical-align:-3px;width:16px;\">" +
	pseud.byline, user_pseud_url(pseud.user, pseud))
	end
	def text_pseud(pseud)
	pseud.byline + " (#{user_pseud_url(pseud.user, pseud)})"
	end

(it does include the kudos icon, but we're OK with that as another way to distinguish registered users from guests). It seems to play nicely with style_bold but we're fine as long as one of the icon or bold is there

[sarken]

Oh, wait, my mistake! commenter_pseud_or_name_text also needs to be updated to use text_pseud (the plain text equivalent of style_pseud_link).

[sarken]

Bilka can't access GitHub right now, but he pointed out we forgot some mailers 🤦

In app/views/admin_mailer/, the following mailers need to be updated to use commenter_pseud_or_name_link and commenter_pseud_or_name_text:

• comment_notification.html.erb
• comment_notification.text.erb
• edited_comment_notification.html.erb
• edited_comment_notification.text.erb