AO3-6625 Replace whitespace in download filenames with underscores #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceithir
approved these changes
Oct 24, 2023
| @@ -53,7 +53,7 @@ | |||
| expect(Download.new(work).file_name).to eq("123456789-123456789-1234") | |||
|
|
|||
| work.title = "123456789 123456789 123456789" | |||
| expect(Download.new(work).file_name).to eq("123456789 123456789") | |||
| expect(Download.new(work).file_name).to eq("123456789_123456789") | |||
| end | |||
There was a problem hiding this comment.
Maybe an additional test for the edge case of a work title having several consecutive spaces like A mystery?
app/models/download.rb
Outdated
| name = extender | ||
| elsif name.length < 3 | ||
| name += "_#{extender}" | ||
| end |
There was a problem hiding this comment.
My JS-addled immediately thought of "simplifying" that using join:
name = [name, "Work_#{work.id}"].compact_blank.join("_") if name.length < 3But not exactly sure this is indeed better.
brianjaustin
approved these changes
Oct 25, 2023
neuroalien
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6625
Purpose
Replaces the whitespace in download filenames with underscores to ensure the Calibre-generated table of contents works on EPUBs for Kindle. (Refer to Jira for more info on why this should fix it despite seeming unconnected.)
Testing Instructions
Refer to Jira.
Credit
Sarken, she/her