AO3-6464 Allow ruby, rt, and rp HTML tags where HTML is allowed

[potpotkettle]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6464

Purpose

The ruby, rt, and rp tags are used to represent ruby annotation. With these tags, the small text marked with rt will be located above the base text marked with ruby. Although there are various complexities that come with more advanced features of ruby annotation (e.g. the tabular syntax, CSS rules to control how to render ruby characters, etc), the intention behind the linked Jira issue seems to be to support the most simple (and common) use cases.

Testing Instructions

To start with, please try posting a new work with the new tags (and with the usual required fields).

Suggested content: <ruby>BigText<rp> (</rp><rt>short_text</rt><rp>)</rp></ruby>

This should work in other places where the limited HTML is allowed (like comments).

References

rb is not included here (thus removed by the sanitizer when entered). I think this could potentially be revisited if and when whatwg/html#1771 is resolved. See also the linked Jira issue for related discussion.

Credit

Potpotkettle (they/them)

[potpotkettle]

Here is a current screenshot.

I have also attached downloaded versions in PDF, AZW3 and MOBI. When viewed from an app called Foliate, the mobi version was rendered with parentheses. The rest were the same as the web site version (annotations above the main text).

[redsummernight]

There's another list at

otwarchive/app/helpers/application_helper.rb

Lines 67 to 74 in 2d92ec1

	def allowed_html_instructions(show_list = false, show_text=true)
	(show_text ? h(ts("Plain text with limited HTML")) : ''.html_safe) +
	link_to_help("html-help") + (show_list ?
	"<code>a, abbr, acronym, address, [alt], [axis], b, big, blockquote, br, caption, center, cite, [class], code,
	col, colgroup, dd, del, dfn, [dir], div, dl, dt, em, h1, h2, h3, h4, h5, h6, [height], hr, [href], i, img,
	ins, kbd, li, [name], ol, p, pre, q, s, samp, small, span, [src], strike, strong, sub, sup, table, tbody, td,
	tfoot, th, thead, [title], tr, tt, u, ul, var, [width]</code>" : "").html_safe
	end

but I don't think we ever set show_list = true anywhere. Can you remove that option and the conditional that uses it?

[potpotkettle]

For all I could find, it was disabled in 1d9f656 (in 2011).

The option is used in app/views/bookmarks/_bookmark_form.html.erb and app/views/comments/_comment_form.html.erb (with show_list=false). I feel like I would be touching parts of the code that's not particularly related to the issue (ruby annotations), but if that's okay, sure, I'll do that.

[redsummernight]

I think it's fine to make these changes. It's unused code that looks puzzling if not updated to include to new tags.

[redsummernight]

You can leave out this test, which is not too related to the current issue (the word counter ignores all HTML tags).

[potpotkettle]

It's true that this is not a test that justifies the other changes in the PR. It would have passed before. So I agree with leaving it out if that's what you mean.

There doesn't seem to be tests that involve parenthesized text, full-width or not, and parentheses might be common things that would warrant tests, but it seems like that's a separate issue to think about.

(That's a long way to say "yes" but I wanted to make sure I have it right.)

[redsummernight]

Yeah, let's leave this alone for now as it's not related to the main changes in the PR.

[redsummernight]

Thank you!

[sarken]

Hey, @potpotkettle! Do you have a few minutes to resolve the merge conflicts on this? If not, no worries, someone else can take them.

[potpotkettle]

Sure, done.

[redsummernight]

Thanks!