AO3-6141 Disable user role checkboxes based on admin permissions #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
redsummernight
changed the title
redsummernight
added
Reviewed: Action Needed
and removed
Coder Has Actioned Review
labels
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
redsummernight
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
sarken
pushed a commit
to sarken/otwarchive
that referenced
this pull request
Jun 24, 2023
…code#4355) * AO3 6141 disable user role checkboxes * please hound * move logic to userpolicy class * please hound * use hash for checking that admin role can edit user role * please hound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6141
Purpose
What does this PR do?
Testing Instructions
How can the Archive's QA team verify that this is working as you intended?
If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.
References
Are there other relevant issues/pull requests/mailing list discussions?
Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.
Cesium-Ice, she/her