Skip to content

Commit

Permalink
AO3-6590 Add reviewdog for linting ERB files (#4604)
Browse files Browse the repository at this point in the history
* AO3-6590 Add reviewdog ERB lint runner

* AO3-6590 Remove erb lint from Hound

It doesn't work. And if that would be fixed in the future, it would be
linting twice.

* AO3-6590 Rename reviewdog workflow to be more generic
  • Loading branch information
Bilka2 authored and weeklies committed Aug 19, 2023
1 parent bbc0a5b commit c0ccf09
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 4 deletions.
27 changes: 27 additions & 0 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Based on https://github.com/tk0miya/action-erblint/blob/main/README.md#example-usage

name: Reviewdog

on: [pull_request]

permissions:
checks: write

jobs:
erb-lint:
name: ERB Lint runner
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v3

- name: Set up Ruby and run bundle install
uses: ruby/setup-ruby@v1
with:
bundler-cache: true

- name: erb-lint
uses: tk0miya/action-erblint@667687e73b44e7b7a710a1204b180f49f80ebb5e
with:
use_bundler: true
reporter: github-pr-check # default
4 changes: 0 additions & 4 deletions .hound.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# Available linter versions:
# http://help.houndci.com/en/articles/2461415-supported-linters

erblint:
enabled: true
config_file: .erb-lint.yml

jshint:
config_file: .jshintrc
ignore_file: .jshintignore
Expand Down

0 comments on commit c0ccf09

Please sign in to comment.