AO3-6587 Fix justifiable spec, cucumber feature and Rubocop style gui…

…dance
otwcode · Dec 15, 2024 · a378d49 · a378d49
1 parent 3c20481
commit a378d49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/models/concerns/justifiable.rb b/app/models/concerns/justifiable.rb
@@ -18,7 +18,9 @@ module Justifiable
   private
 
   def strip_octothorpe
-    self.ticket_number = self.ticket_number.delete_prefix("#") unless self.ticket_number.nil?
+    unless ticket_number.is_a?(Integer)
+      self.ticket_number = self.ticket_number.delete_prefix("#") unless self.ticket_number.nil?
+    end
   end
 
   def enabled?

diff --git a/spec/models/concerns/justifiable_spec.rb b/spec/models/concerns/justifiable_spec.rb
@@ -26,7 +26,7 @@
 
       record.assign_attributes(attributes)
       expect(record).not_to be_valid
-      expect(record.errors[:ticket_number]).to contain_exactly("can't be blank", "is not a number")
+      expect(record.errors[:ticket_number]).to contain_exactly("can't be blank", "may begin with an # and otherwise contain only numbers.")
       expect(record.ticket_url).to be_nil
     end