AO3-6625 Remove redundant assignment and prefer zero? to == 0

otwcode · Oct 23, 2023 · 9d572e1 · 9d572e1
1 parent afdf8e1
commit 9d572e1
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/models/download.rb b/app/models/download.rb
@@ -55,7 +55,7 @@ def file_type_from_mime(mime)
   def file_name
     name = clean(work.title)
     extender = "Work_#{work.id}"
-    if name.length == 0
+    if name.length.zero?
       name = extender
     elsif name.length < 3
       name += "_#{extender}"
@@ -139,7 +139,6 @@ def clean(string)
     string = string.gsub(/ +/, " ")
     string = string.strip
     string = string.truncate(24, separator: ' ', omission: '')
-    string = string.gsub(/\s/, "_")
-    string
+    string.gsub(/\s/, "_")
   end
 end