Skip to content

Commit

Permalink
Some sort of solution for seemingly noop
Browse files Browse the repository at this point in the history
  • Loading branch information
@ceithir
ceithir committed Oct 24, 2023
1 parent cddde94 commit 3a56132
Showing 1 changed file with 28 additions and 26 deletions.
54 changes: 28 additions & 26 deletions app/views/tag_wranglings/index.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -104,32 +104,34 @@

<tbody>
<% @tags.each do |tag| %>
<tr>
<th scope="row" title="<%= ts('tag') %>">
<%= check_box_tag 'selected_tags[]', tag.id, nil, id: "selected_tags_#{tag.id}" %>
<%= label_tag "selected_tags_#{tag.id}", "#{tag.name}" %>
</th>

<td title="<%= ts('created') %>"><%= l(tag.created_at.to_date) %></td>

<td title="<%= ts('canonical?') %>">
<% if tag.canonical? %>
<%= ts('Yes') %>
<% else %>
<%= check_box_tag 'canonicals[]', tag.id, tag.canonical?, id: "canonicals_#{tag.id}" %>
<% end %>
</td>

<td title="<%= ts("taggings") %>"><%= tag.taggings_count_cache %></td>

<td>
<ul class="actions" role="navigation">
<li><%= link_to ts('Edit'), {controller: :tags, action: :edit, id: tag} %></li>
<li><%= link_to ts('Wrangle'), {controller: :tags, action: :wrangle, id: tag} %></li>
<li><%= link_to ts('Works'), {controller: :works, action: :index, tag_id: tag} %></li>
</ul>
</td>
</tr>
<% if tag.unwrangled? %>
<tr>
<th scope="row" title="<%= ts('tag') %>">

Check failure on line 109 in app/views/tag_wranglings/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Raw Output:
app/views/tag_wranglings/index.html.erb:109:50: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
<%= check_box_tag 'selected_tags[]', tag.id, nil, id: "selected_tags_#{tag.id}" %>

Check failure on line 110 in app/views/tag_wranglings/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Raw Output:
app/views/tag_wranglings/index.html.erb:110:40: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
<%= label_tag "selected_tags_#{tag.id}", "#{tag.name}" %>

Check failure on line 111 in app/views/tag_wranglings/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Style/RedundantInterpolation: Prefer `to_s` over string interpolation.

Raw Output:
app/views/tag_wranglings/index.html.erb:111:63: Style/RedundantInterpolation: Prefer `to_s` over string interpolation.
</th>

<td title="<%= ts('created') %>"><%= l(tag.created_at.to_date) %></td>

Check failure on line 114 in app/views/tag_wranglings/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Raw Output:
app/views/tag_wranglings/index.html.erb:114:38: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

<td title="<%= ts('canonical?') %>">

Check failure on line 116 in app/views/tag_wranglings/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Raw Output:
app/views/tag_wranglings/index.html.erb:116:38: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
<% if tag.canonical? %>
<%= ts('Yes') %>

Check failure on line 118 in app/views/tag_wranglings/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Raw Output:
app/views/tag_wranglings/index.html.erb:118:31: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
<% else %>
<%= check_box_tag 'canonicals[]', tag.id, tag.canonical?, id: "canonicals_#{tag.id}" %>

Check failure on line 120 in app/views/tag_wranglings/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Raw Output:
app/views/tag_wranglings/index.html.erb:120:42: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
<% end %>
</td>

<td title="<%= ts("taggings") %>"><%= tag.taggings_count_cache %></td>

<td>
<ul class="actions" role="navigation">
<li><%= link_to ts('Edit'), {controller: :tags, action: :edit, id: tag} %></li>

Check failure on line 128 in app/views/tag_wranglings/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.

Raw Output:
app/views/tag_wranglings/index.html.erb:128:52: Layout/SpaceInsideHashLiteralBraces: Space inside { missing.

Check failure on line 128 in app/views/tag_wranglings/index.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[] reported by reviewdog 🐶
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

Raw Output:
app/views/tag_wranglings/index.html.erb:128:94: Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
<li><%= link_to ts('Wrangle'), {controller: :tags, action: :wrangle, id: tag} %></li>
<li><%= link_to ts('Works'), {controller: :works, action: :index, tag_id: tag} %></li>
</ul>
</td>
</tr>
<% end %>
<% end %>
</tbody>
</table>
Expand Down

0 comments on commit 3a56132

Please sign in to comment.