AO3-6566 ARIA controls must contain the exact ID

The ID of the modal controlled by the link to modal is `modal`. The hash sign must not be included in the reference to the element.
otwcode · Jul 24, 2023 · 145e9ad · 145e9ad
1 parent f09c964
commit 145e9ad
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -150,7 +150,7 @@ def link_to_modal(content = "", options = {})
     options[:for] ||= ""
     options[:title] ||= options[:for]
 
-    html_options = { "class" => options[:class] + " modal", "title" => options[:title], "aria-controls" => "#modal" }
+    html_options = { "class" => options[:class] + " modal", "title" => options[:title], "aria-controls" => "modal" }
     link_to content, options[:for], html_options
   end
 

diff --git a/public/javascripts/ao3modal.js b/public/javascripts/ao3modal.js
@@ -193,7 +193,7 @@ jQuery(document).ready(function() {
                         .append(img);
 
                 a.addClass('modal modal-attached')
-                    .attr('aria-controls', '#modal')
+                    .attr('aria-controls', 'modal')
                     .filter(function() {
                         return $(this).closest('.userstuff').length === 0;
                     }).click(function(event){

diff --git a/public/javascripts/ao3modal.min.js b/public/javascripts/ao3modal.min.js