AO3-6859 Fix admins being disallowed from tags pages #1514
reviewdog.yml
on: pull_request
Rubocop
57s
ERB Lint runner
1m 46s
Annotations
1 error and 6 warnings
Rubocop
Process completed with exit code 1.
|
Rubocop:
app/controllers/tags_controller.rb#L63
[rubocop] reported by reviewdog 🐶
Prefer Rails built-in `t` helper over `ts` and move the text into the yml file. `ts` is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
Raw Output:
app/controllers/tags_controller.rb:63:25: C: I18n/DeprecatedHelper: Prefer Rails built-in `t` helper over `ts` and move the text into the yml file. `ts` is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
|
Rubocop:
app/controllers/tags_controller.rb#L63
[rubocop] reported by reviewdog 🐶
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Raw Output:
app/controllers/tags_controller.rb:63:28: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Rubocop:
app/controllers/tags_controller.rb#L66
[rubocop] reported by reviewdog 🐶
Prefer Rails built-in `t` helper over `ts` and move the text into the yml file. `ts` is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
Raw Output:
app/controllers/tags_controller.rb:66:25: C: I18n/DeprecatedHelper: Prefer Rails built-in `t` helper over `ts` and move the text into the yml file. `ts` is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
|
Rubocop:
app/controllers/tags_controller.rb#L66
[rubocop] reported by reviewdog 🐶
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Raw Output:
app/controllers/tags_controller.rb:66:28: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Rubocop:
app/controllers/tags_controller.rb#L72
[rubocop] reported by reviewdog 🐶
Use the return of the conditional for variable assignment and comparison.
Raw Output:
app/controllers/tags_controller.rb:72:7: C: Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.
|
ERB Lint runner
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|