Enable imsize to be used in _posts directory #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, this plugin did not produce proper links for images inside my `sources/_posts` directory. The links seemed to be generated in the _posts directory, which was not part of the paths generated by hexo in the posts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch corrects broken links generated by hexo-image-sizes in the scenario where
post_asset_folder: trueand the folder is a child ofsource/_posts.Prior to this patch the
{% imsize %}tags produce broken links when used inside the _posts directory. These links are broken because they include/_posts/as a prefix to the src image.Hexo removes the _posts prefix and replaces it with the permalink path specified in the config file. Prior to this patch, hexo-image-sizes does not know to do this. This patch introduces new behavior to remove the _posts directory if it is present in the source path.
Note that this fix has only been verified in two scenarios (
hexo new pageandhexo new post), and only on my Windows machine.Also note that I have not separated this patch from my previous chain of fixes, since I am currently running Windows. I can produce a separated patch for upstreaming if you can test it.