You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
When using TransitionGroup and solid-app-router with suspense and lazy components exit transition occurs too early.
This is regression, the last working version was 0.7.5.
Reproduction
See when clicking link that transition occurs instantly despite route still being lazily loaded. Transition should not occur until new route is ready.
I'd have to dig into how suspense works in order to fix this; seems that createComputed ignores(?) suspense. Here's a workaround that hopefully doesn't introduce any issues: https://codesandbox.io/s/tender-bell-kxtuv?file=/index.js
Unsure if this breaks anything, but based on my understanding it shouldn't outside of some very edge cases (setting the TransitionGroup children then expecting the TG to update before effects run)
closes issue #6
When using
TransitionGroup
andsolid-app-router
with suspense and lazy components exit transition occurs too early.This is regression, the last working version was 0.7.5.
Reproduction
See when clicking link that transition occurs instantly despite route still being lazily loaded. Transition should not occur until new route is ready.
Sample code:
The text was updated successfully, but these errors were encountered: