Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy rete limiter #90

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Add copy rete limiter #90

merged 2 commits into from
Oct 31, 2022

Conversation

imsunv
Copy link

@imsunv imsunv commented Oct 18, 2022

solve #89

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #90 (432adff) into main (d69252f) will decrease coverage by 5.68%.
The diff coverage is 6.25%.

❗ Current head 432adff differs from pull request most recent head 155df18. Consider uploading reports for the commit 155df18 to get more accurate results

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   77.19%   71.50%   -5.69%     
==========================================
  Files           9       10       +1     
  Lines         171      186      +15     
==========================================
+ Hits          132      133       +1     
- Misses         19       32      +13     
- Partials       20       21       +1     
Impacted Files Coverage Δ
options.go 85.71% <ø> (ø)
ratelimited_reader.go 0.00% <0.00%> (ø)
copy.go 75.23% <25.00%> (-1.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@otiai10 otiai10 self-requested a review October 25, 2022 03:55
@otiai10 otiai10 mentioned this pull request Oct 25, 2022
@otiai10
Copy link
Owner

otiai10 commented Oct 26, 2022

Thank you @imsunv.

I don't want to include specific algorithm inside this.
Thus, I created #91 to allow users to define their custom Reader.

Please take a look #91

@otiai10 otiai10 merged commit 155df18 into otiai10:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants