Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect that time is required for data in the factory #4

Merged
merged 1 commit into from
May 2, 2023
Merged

Reflect that time is required for data in the factory #4

merged 1 commit into from
May 2, 2023

Conversation

signed
Copy link
Contributor

@signed signed commented Oct 19, 2022 •
edited
Loading

The time attribute on entry is required.
Enforce it in the factory method?

marcphilipp
marcphilipp approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good call! 👍

@marcphilipp marcphilipp marked this pull request as ready for review May 1, 2023 14:42
@marcphilipp marcphilipp changed the title reflect that time is required for data in the factory Reflect that time is required for data in the factory May 2, 2023
@marcphilipp marcphilipp merged commit e9b2832 into ota4j-team:main May 2, 2023
marcphilipp added a commit that referenced this pull request May 3, 2023
@marcphilipp
Revert "Reflect that time is required for data in the factory (#4)"
2a132f2 
This reverts commit e9b2832.
@marcphilipp marcphilipp added this to the 0.1.0-M2 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@signed @marcphilipp