Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incompatibility with Woodstox StAX implementation #106

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Fix incompatibility with Woodstox StAX implementation #106

merged 3 commits into from
Apr 19, 2024

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Apr 19, 2024 •
edited
Loading

  • Add separate test task to test against Woodstox StAX implementation
  • Flush writers before/after appending line breaks

Fixes #105.

@marcphilipp marcphilipp self-assigned this Apr 19, 2024
mmerdes
mmerdes approved these changes Apr 19, 2024
View reviewed changes
Copy link

@mmerdes mmerdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me - see some minor comments below.
Cannot judge the gradle part so well - but then you are the expert here ;)

events/src/main/java/org/opentest4j/reporting/events/api/DefaultDocumentWriter.java Outdated Show resolved Hide resolved
events/src/main/java/org/opentest4j/reporting/events/api/DefaultDocumentWriter.java Show resolved Hide resolved
@marcphilipp marcphilipp merged commit 78a7838 into main Apr 19, 2024
7 checks passed
@marcphilipp marcphilipp deleted the marc/105-woodstox-fix branch April 19, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmerdes mmerdes mmerdes approved these changes

Assignees

@marcphilipp marcphilipp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XML output may not be well formed if a third party XMLOutputFactory is used
2 participants
@marcphilipp @mmerdes