Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer does not close after clicking on a link #8

Closed
rictorres opened this issue Nov 16, 2013 · 2 comments
Closed

Drawer does not close after clicking on a link #8

rictorres opened this issue Nov 16, 2013 · 2 comments
Labels
enhancement

Comments

@rictorres
Copy link

When you click a link on the drawer, it doesn't close automatically. This behaviour blocks page scrolling, forcing the user to click on the page content to scroll.
@oswaldoacauan
Copy link
Owner

This is a expected behavior.

But i think will be nice to only close drawer when its a [data-pjax] anchor. What your think @rictorres?

@rictorres
Copy link
Author

Yep, I agree.
Also, I think the user is more familiar with this approach, since it's used on so many places (eg.: Facebook).

oswaldoacauan added a commit that referenced this issue Nov 18, 2013
@oswaldoacauan
feat(drawer): Close after clicking on pjax link #8
10134a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rictorres @oswaldoacauan