Build command implementation #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
- coerce string `build:` directory into full build context object - allow only one of either `build:` or `image:` fields Signed-off-by: Robert Detjens <[email protected]>
also adds a directory field to ChallengeConfig struct to hold the reference path for the challenge Signed-off-by: Robert Detjens <[email protected]>
bollard wants to use HashMap to talk to the docker daemon, and we don't need the extra features BTreeMap offers. simpler to agree on HashMap. Signed-off-by: Robert Detjens <[email protected]>
does not push yet, and probably missing other stuff Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Makes more sense for these to be comments. Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
detjensrobert
force-pushed
the
dr/build-implementation
branch
from
9f244b8
to
147a138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on
#18, #20