This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
deploy: Add a --no-imgref option
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to refresh the |
In coreos/coreos-assembler#2523 we taught coreos-assembler how to generate disk images with a "pre-pulled" container image. This means that the *first* OS update will use shared layers. However...right now running e.g. `rpm-ostree rebase quay.io/newimage` won't necessarily prune the previous image. (This may be considered a bug) But in practice, particularly for RHEL CoreOS we may not want to have a default image reference - we don't (necessarily) want typing `rpm-ostree upgrade` to do something. With this, we can effectively pre-pull just the layers but not the final image.
cgwalters
force-pushed
the
deploy-unlinked
branch
from
d2cfe11
to
bec7c0a
Compare
The CI was already fixed in #363 - this just needed a rebase 🏄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In coreos/coreos-assembler#2523 we
taught coreos-assembler how to generate disk images with a
"pre-pulled" container image. This means that the first OS update
will use shared layers.
However...right now running e.g.
rpm-ostree rebase quay.io/newimagewon't necessarily prune the previous image. (This may be considered
a bug)
But in practice, particularly for RHEL CoreOS we may not want to have
a default image reference - we don't (necessarily) want typing
rpm-ostree upgradeto do something.With this, we can effectively pre-pull just the layers but not
the final image.