Full refactoring and async usage (Release 0.4.0) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FalseR20
force-pushed
the
refactor/full
branch
from
2038b30
to
2e8da70
Compare
NikitaZotov
requested changes
Sep 11, 2023
NikitaZotov
requested changes
Sep 21, 2023
|
|
||
| async def _send_with_reconnect(self, data: str) -> None: | ||
| retries: int = self.reconnect_retries | ||
| while True: |
There was a problem hiding this comment.
Can we use another condition for this cycle instead?
There was a problem hiding this comment.
Changed on for statement
| from sc_client.testing.response_callback import ResponseCallback | ||
|
|
||
|
|
||
| class WebsocketStub: |
There was a problem hiding this comment.
Can you add tests to check performance of sc-client?
|
Can I check your changes in sc-web? |
Yeah. Also passed the integrated py-sc-kpm tests, so you can rest assured that everything works as before |
FalseR20
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full refactoring of structure
[0.4.0]
Added
Changed
ScTypeto models directoryvaluefield forScAddrandScTypeas property and cannot be changed in runtime__lt__method for the ability to sort ScAddrsRemoved
ScTemplatetriplets (now tuple and operator>>)ScTemplateResult:results.size(), uselen(results)results.get(...), useresults[...]results.for_each_triple(...), usefor src, edge, trd in results ...ScAgent,ScModuleandScKeynodes(now in kpm)