Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Insertion Indices #7

Merged
merged 9 commits into from
Jan 5, 2016
Merged

Fix Insertion Indices #7

merged 9 commits into from
Jan 5, 2016

Commits on Jan 5, 2016

  1. Minor: fix white space

    Joachim Bondo committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    50cf7bb View commit details
    Browse the repository at this point in the history

  2. Use indices into target for insertions and substitutions 

    This reflects how UITableView wants its changes applied within a
beginUpdates/endUpdates block.

Tests are updated to reflect how first deletions are made, then
insertions and substitutions. Note, indices for a .Move correspond to
those of a separate delete and insert.

Fixes #2.
    Joachim Bondo committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    b0d8a56 View commit details
    Browse the repository at this point in the history

  3. Add tests to verify indices of deletions, insertions

    Joachim Bondo committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    db48df7 View commit details
    Browse the repository at this point in the history

  4. Add tests from @davedelong tweet 

    Wouldn't mind to have his whole test suite to be honest.
    Joachim Bondo committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    4199870 View commit details
    Browse the repository at this point in the history

  5. Add test from Apple's UITableView documentation

    Joachim Bondo committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    e565c01 View commit details
    Browse the repository at this point in the history

  6. Add tests exercising all four operations

    Joachim Bondo committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    06af0cd View commit details
    Browse the repository at this point in the history

  7. Update README with more information on indices

    Joachim Bondo committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    4bd94f9 View commit details
    Browse the repository at this point in the history

  8. Update code to use example from Apple's guide

    Joachim Bondo committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    ab23042 View commit details
    Browse the repository at this point in the history

  9. Change DeLong link from Twitter to GitHub

    Joachim Bondo committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    18f62cd View commit details
    Browse the repository at this point in the history