Fix Substitution Indexes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply following the documentation: > Deletion and reloading operations within an animation block specify > which rows and sections in the original table should be removed or > reloaded; insertions specify which rows and sections should be added > to the resulting table.
That is, those tests where a .Substitution is preceeded by .Insertion or .Deletion.
Instead of including the source file in the test target.
Instead, from .Move edits, do corresponding deletions and insertions. The calls, moveRowAtIndexPath and moveItemAtIndexPath, don't currently work with the indexes in Changeset. This will be fixed in a future version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12 by correcting
.Substitutionindexes to point into the source collection as documented by Apple.Related:
.Moveedit indexes are currently incompatible with table/collection view animation blocks. This would cause the test app to throw an exception. So instead of callingmoveRowAtIndexPathandmoveItemAtIndexPathwith.Moveindexes, moves are now composed by deletion/insertion pairs. This issue will be fixed separately.