Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 mark codeApproved and sastToolRunsOnAllCommits as experimental #4242

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

doc change

What is the current behavior?

What is the new behavior (if this is a feature change)?**

The motivation behind the probes won't change, but I want to reserve the ability to change the probe to return 1 finding per changeset. We've received feedback that being able to see which individual change passes or doesn't pass is helpful (#4237 (comment)).

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

The motivation behind the probes won't change, but I want to reserve
the ability to change the probe to return 1 finding per changeset. We've
received feedback that being able to see which individual change passes or
doesn't pass is helpful.

Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock spencerschrock requested a review from a team as a code owner July 15, 2024 21:27
@spencerschrock spencerschrock requested review from naveensrinivasan and removed request for a team July 15, 2024 21:27
@spencerschrock spencerschrock enabled auto-merge (squash) July 15, 2024 21:28
@spencerschrock spencerschrock merged commit bc30d0f into ossf:main Jul 15, 2024
39 checks passed
@spencerschrock spencerschrock deleted the mark-probes-experimental branch July 15, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants