🌱 Add config e2e test and fix README #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <[email protected]>
The old syntax was changed so the README was out of date. This was exposed when setting up the e2e repo. Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
naveensrinivasan,
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
|
Note: the e2e test is failing because the experimental gate is still there. |
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
test addition
What is the current behavior?
No e2e test, out of date readme
What is the new behavior (if this is a feature change)?**
Basic e2e test, updated readme
Which issue(s) this PR fixes
Related to #4048
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)