Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Migrate other RunScorecard callers #4208

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

api cleanup. I grouped these separately as they're lower impact

What is the current behavior?

Use pkg.RunScorecard

What is the new behavior (if this is a feature change)?**

Use pkg.Run

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Follow up of #3717

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock spencerschrock marked this pull request as ready for review July 8, 2024 16:40
@spencerschrock spencerschrock requested a review from a team as a code owner July 8, 2024 16:40
@spencerschrock spencerschrock requested review from naveensrinivasan and raghavkaul and removed request for a team July 8, 2024 16:40
@spencerschrock
Copy link
Member Author

Note: 8f5b397 was cherry picked from #4203, so the implementation is identical. I can resolve any merge conflict.

Copy link
Contributor

@raghavkaul raghavkaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spencerschrock spencerschrock enabled auto-merge (squash) July 8, 2024 17:39
@spencerschrock spencerschrock merged commit 6a58163 into ossf:main Jul 8, 2024
36 checks passed
@spencerschrock spencerschrock deleted the migrate-other-callers branch July 8, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants