-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 maintainer annotations: improve annotation file validation #4162
Merged
raghavkaul
merged 8 commits into
ossf:main
from
raghavkaul:feature-4048-parseannotations
Jul 2, 2024
Merged
🌱 maintainer annotations: improve annotation file validation #4162
raghavkaul
merged 8 commits into
ossf:main
from
raghavkaul:feature-4048-parseannotations
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
requested review from
naveensrinivasan and
spencerschrock
and removed request for
a team
June 10, 2024 18:55
raghavkaul
temporarily deployed
to
integration-test
June 10, 2024 18:56 — with
GitHub Actions
Inactive
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
June 17, 2024 16:17 — with
GitHub Actions
Inactive
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
had a problem deploying
to
integration-test
June 17, 2024 16:55 — with
GitHub Actions
Failure
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
had a problem deploying
to
integration-test
June 17, 2024 16:57 — with
GitHub Actions
Failure
This pull request has been marked stale because it has been open for 10 days with no activity |
raghavkaul
had a problem deploying
to
integration-test
July 1, 2024 14:27 — with
GitHub Actions
Failure
raghavkaul
had a problem deploying
to
integration-test
July 1, 2024 16:04 — with
GitHub Actions
Failure
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
force-pushed
the
feature-4048-parseannotations
branch
from
July 1, 2024 16:08
80356d5
to
7af2164
Compare
raghavkaul
temporarily deployed
to
integration-test
July 1, 2024 16:08 — with
GitHub Actions
Inactive
raghavkaul
force-pushed
the
feature-4048-parseannotations
branch
from
July 1, 2024 16:11
7af2164
to
4a71029
Compare
raghavkaul
temporarily deployed
to
integration-test
July 1, 2024 16:11 — with
GitHub Actions
Inactive
spencerschrock
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks!
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
July 2, 2024 15:34 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Validate maintainer annotation check names against full list of check names instead of checks passed via
runScorecard
Which issue(s) this PR fixes
Addresses #4048.