Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 maintainer annotations: improve annotation file validation #4162

Merged
merged 8 commits into from
Jul 2, 2024

Conversation

raghavkaul
Copy link
Contributor

What kind of change does this PR introduce?

Validate maintainer annotation check names against full list of check names instead of checks passed via runScorecard

Which issue(s) this PR fixes

Addresses #4048.

@raghavkaul raghavkaul requested a review from a team as a code owner June 10, 2024 18:55
@raghavkaul raghavkaul requested review from naveensrinivasan and spencerschrock and removed request for a team June 10, 2024 18:55
@raghavkaul raghavkaul temporarily deployed to integration-test June 10, 2024 18:56 — with GitHub Actions Inactive
Signed-off-by: Raghav Kaul <[email protected]>
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config_test.go Outdated Show resolved Hide resolved
config/config_test.go Outdated Show resolved Hide resolved
Signed-off-by: Raghav Kaul <[email protected]>
Signed-off-by: Raghav Kaul <[email protected]>
Copy link

This pull request has been marked stale because it has been open for 10 days with no activity

Signed-off-by: Raghav Kaul <[email protected]>
@raghavkaul raghavkaul force-pushed the feature-4048-parseannotations branch from 80356d5 to 7af2164 Compare July 1, 2024 16:08
@raghavkaul raghavkaul temporarily deployed to integration-test July 1, 2024 16:08 — with GitHub Actions Inactive
@raghavkaul raghavkaul force-pushed the feature-4048-parseannotations branch from 7af2164 to 4a71029 Compare July 1, 2024 16:11
@raghavkaul raghavkaul temporarily deployed to integration-test July 1, 2024 16:11 — with GitHub Actions Inactive
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

config/config_test.go Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Jul 2, 2024
@raghavkaul raghavkaul enabled auto-merge (squash) July 2, 2024 15:33
@raghavkaul raghavkaul temporarily deployed to integration-test July 2, 2024 15:34 — with GitHub Actions Inactive
@raghavkaul raghavkaul merged commit 28337f1 into ossf:main Jul 2, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants