🐛 Token-Permissions: use same text for read token details as write token details #4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an unintentional regression from v4.13.1 Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
naveensrinivasan
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
/scdiff generate Token-Permissions |
laurentsimon
approved these changes
Apr 12, 2024
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4025 +/- ##
==========================================
- Coverage 66.70% 66.53% -0.18%
==========================================
Files 223 222 -1
Lines 16070 16024 -46
==========================================
- Hits 10719 10661 -58
- Misses 4688 4691 +3
- Partials 663 672 +9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix? This was an unintentional regression from v4.13.1
What is the current behavior?
The detail used to (v4.13.1) say something like:
But the conversion PR (#3816) replaced the individual scopes with a generic message:
What is the new behavior (if this is a feature change)?**
Read permissions findings use the same text helper function that write permission findings do, which matches what v4.13.1 did.
Which issue(s) this PR fixes
NONE (preparing for release)
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)