⚠️ Delegate logging decisions to the checks instead of a helper #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may not be the final form, we may support want to support passing a map of probe+outcome to level mappings. Signed-off-by: Spencer Schrock <[email protected]>
For now, we only use one probe so logging is simple. Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
This changes the logging of an error state, but it's not one we expect to see. Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4019 +/- ##
==========================================
- Coverage 66.70% 60.11% -6.59%
==========================================
Files 223 207 -16
Lines 16070 15268 -802
==========================================
- Hits 10719 9179 -1540
- Misses 4688 5421 +733
- Partials 663 668 +5 |
|
/scdiff generate Dependency-Update-Tool,Fuzzing,License,Maintained,Packaging,Security-Policy,Signed-Releases,Vulnerabilities |
scdiff caught a lot of new details being generated. So going to try removing them Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
/scdiff generate Dependency-Update-Tool,Fuzzing,License,Maintained,Packaging,Security-Policy,Signed-Releases,Vulnerabilities |
|
I will have to do yet another follow up for flipping the probe outcomes around. |
laurentsimon
approved these changes
Apr 9, 2024
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
breaking change since we're deleting functions
What is the current behavior?
checks use
checker.LogFindingsbecause logging used to be more standardized when we used Positive and Negative for outcomes.What is the new behavior (if this is a feature change)?**
The individual checks make decisions based on how to log a particular finding. Since it now depends on probe name and outcome.
Which issue(s) this PR fixes
Related to #3654
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)