⚠️ Switch Outcome type to string
#4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, these were introduced as ints to enable ordering between them. Today, I don't see the value in doing that, and it makes the output less readable. Signed-off-by: Spencer Schrock <[email protected]>
previously, OutcomeNegative had the integer value of 0. So some tests didnt specify the outcome and happened to pass due to the zero value. This also fixes the tests names while I was here. Signed-off-by: Spencer Schrock <[email protected]>
this change demonstrates the reason for this PR. Human readable outcomes are good! Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
naveensrinivasan and
justaugustus
and removed request for
a team
spencerschrock
requested review from
laurentsimon
and removed request for
naveensrinivasan
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4006 +/- ##
==========================================
+ Coverage 66.70% 70.49% +3.79%
==========================================
Files 223 223
Lines 16070 16070
==========================================
+ Hits 10719 11329 +610
+ Misses 4688 4021 -667
- Partials 663 720 +57 |
laurentsimon
approved these changes
Apr 6, 2024
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
Yes. And that will also be 2 changes so the important changes don't get lost in a big diff.
|
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
structured result cleanup which is technically a breaking change
What is the current behavior?
Outcome is an int based type
What is the new behavior (if this is a feature change)?**
Outcome is a string based type, which leads to better output format
Which issue(s) this PR fixes
Related to #2928 (comment)
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)