🌱 Add ProjectPackageClient interface and deps.dev default client #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3954 +/- ##
==========================================
- Coverage 73.83% 66.04% -7.80%
==========================================
Files 219 226 +7
Lines 15987 16290 +303
==========================================
- Hits 11804 10758 -1046
- Misses 3430 4856 +1426
+ Partials 753 676 -77 |
raghavkaul
changed the title
|
This pull request has been marked stale because it has been open for 10 days with no activity |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
raghavkaul
requested review from
justaugustus and
spencerschrock
and removed request for
a team
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
There was a problem hiding this comment.
Can we throw everything under an internal folder while experimenting, so we can change things later without breaking changes?
maybe internal/clients or internal/clients/depsdev ? We do this already with nuget client for example, which is marked as internal in cmd/internal/nuget
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
approved these changes
May 8, 2024
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This change adds a new client that allows Scorecard to retrieve package versions for a repository. A
ProjectPackageVersion.Versionis a package version published by a repository.Instead of looking up a repository directly in a package manager, this interface allows Scorecard to handle multiple project package versions, i.e. packages with different names than their source repos, and monorepos that publish multiple packages.
We implement a deps.dev client for this interface using GetProjectPackageVersions: