🐛 Branch-Protection: use debug message when unsure if PRs are required #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning when the data isn't available isn't intended. Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
naveensrinivasan and
justaugustus
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3917 +/- ##
==========================================
+ Coverage 66.67% 68.61% +1.93%
==========================================
Files 234 234
Lines 15864 15859 -5
==========================================
+ Hits 10577 10881 +304
+ Misses 4633 4287 -346
- Partials 654 691 +37 |
raghavkaul
approved these changes
Mar 6, 2024
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
ossf#3917) warning when the data isn't available isn't intended. Signed-off-by: Spencer Schrock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
When run with a non-admin token, if we cant tell if PRs are required, we throw a warning.
What is the new behavior (if this is a feature change)?**
Since requiring PRs is listed as potentially admin only data, not having the data is now DEBUG, not WARN.
scorecard/docs/checks.md
Lines 113 to 115 in 90a3708
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
I got rid of the
switchstatement since the function is only called by 3 probes, and all of them want that behavior.Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)