🌱 use ValidateTestReturn for Code-Review tests #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using ValidateTestReturn, we can get more actionable failure messages Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
raghavkaul and
laurentsimon
and removed request for
a team
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
commented
Feb 22, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3897 +/- ##
==========================================
- Coverage 75.50% 70.67% -4.84%
==========================================
Files 231 231
Lines 15669 15669
==========================================
- Hits 11831 11074 -757
- Misses 3109 3917 +808
+ Partials 729 678 -51 |
laurentsimon
approved these changes
Feb 23, 2024
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
* check code review log messages, not just score By using ValidateTestReturn, we can get more actionable failure messages Signed-off-by: Spencer Schrock <[email protected]> * simplify error checking Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
test cleanup, similar to #3872.
This is the first step before hooking up the Code-Review probes to the evaluation code
What is the current behavior?
we only checked the result score, which produces test failures without clear actionable feedback.
What is the new behavior (if this is a feature change)?**
ctrl.Finish()is removed, as it's not needed after Go 1.14Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)