Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update Go toolchain to 1.22 #3859

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

Go version bump

What is the current behavior?

Use Go 1.21

What is the new behavior (if this is a feature change)?**

  • Use Go 1.22 for our CI and dockerfiles.
  • Our minimum Go version in our go.mod is unchanged
    • I did bump the tools/go.mod proactively incase any of our tools switch to requiring 1.22, this makes it so we dependabot PRs don't fail later
  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

Signed-off-by: Spencer Schrock <[email protected]>
no one imports this, so we can bump it now and
avoid issues in the future where we need to upgrade.

Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock spencerschrock requested a review from a team as a code owner February 7, 2024 19:09
@spencerschrock spencerschrock requested review from naveensrinivasan and justaugustus and removed request for a team February 7, 2024 19:09
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #3859 (66e7cb8) into main (ca944e8) will decrease coverage by 3.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3859      +/-   ##
==========================================
- Coverage   66.85%   63.86%   -3.00%     
==========================================
  Files         232      218      -14     
  Lines       15747    14790     -957     
==========================================
- Hits        10527     9445    -1082     
- Misses       4586     4690     +104     
- Partials      634      655      +21     

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@spencerschrock spencerschrock merged commit 64d3307 into ossf:main Feb 7, 2024
41 checks passed
@spencerschrock spencerschrock deleted the go-1.22 branch February 7, 2024 19:36
fhoeborn pushed a commit to fhoeborn/scorecard that referenced this pull request Apr 1, 2024
* update workflows to use go 1.22

Signed-off-by: Spencer Schrock <[email protected]>

* update tools go.mod to 1.22.

no one imports this, so we can bump it now and
avoid issues in the future where we need to upgrade.

Signed-off-by: Spencer Schrock <[email protected]>

* bump docker files

Signed-off-by: Spencer Schrock <[email protected]>

---------

Signed-off-by: Spencer Schrock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants