-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update Go toolchain to 1.22 #3859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <[email protected]>
no one imports this, so we can bump it now and avoid issues in the future where we need to upgrade. Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
naveensrinivasan and
justaugustus
and removed request for
a team
February 7, 2024 19:09
spencerschrock
temporarily deployed
to
integration-test
February 7, 2024 19:10 — with
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3859 +/- ##
==========================================
- Coverage 66.85% 63.86% -3.00%
==========================================
Files 232 218 -14
Lines 15747 14790 -957
==========================================
- Hits 10527 9445 -1082
- Misses 4586 4690 +104
- Partials 634 655 +21 |
naveensrinivasan
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
* update workflows to use go 1.22 Signed-off-by: Spencer Schrock <[email protected]> * update tools go.mod to 1.22. no one imports this, so we can bump it now and avoid issues in the future where we need to upgrade. Signed-off-by: Spencer Schrock <[email protected]> * bump docker files Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Go version bump
What is the current behavior?
Use Go 1.21
What is the new behavior (if this is a feature change)?**
go.mod
is unchangedtools/go.mod
proactively incase any of our tools switch to requiring 1.22, this makes it so we dependabot PRs don't fail laterWhich issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)