🌱 Convert pinned dependencies to probe #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
requested review from
justaugustus and
laurentsimon
and removed request for
a team
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
AdamKorcz
force-pushed
the
pinned-deps-to-probes
branch
from
d2bc061 to
b42e010
Compare
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
==========================================
- Coverage 68.90% 68.80% -0.11%
==========================================
Files 231 232 +1
Lines 15669 15682 +13
==========================================
- Hits 10797 10790 -7
- Misses 4206 4223 +17
- Partials 666 669 +3 |
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
requested review from
spencerschrock
and removed request for
laurentsimon
spencerschrock
approved these changes
Jan 30, 2024
|
/scdiff generate Pinned-Dependencies |
2 tasks
AdamKorcz
force-pushed
the
pinned-deps-to-probes
branch
from
88f9018 to
2d2bb30
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
AdamKorcz
force-pushed
the
pinned-deps-to-probes
branch
from
d594ef5 to
1d58fbc
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: AdamKorcz <[email protected]>
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
@spencerschrock PTAL again. |
|
/scdiff generate Pinned-Dependencies |
LGTM. Will merge on Monday (just in case theres anything we didn't catch, it gives us more time to catch it before the cron uses it) |
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
* 🌱 Convert pinned dependencies to probe Signed-off-by: Adam Korczynski <[email protected]> * add more tests Signed-off-by: Adam Korczynski <[email protected]> * add checks unit test Signed-off-by: Adam Korczynski <[email protected]> * fix year in probe header and add mising test file Signed-off-by: Adam Korczynski <[email protected]> * Change usage of ValidateTestReturn Signed-off-by: Adam Korczynski <[email protected]> * rename test Signed-off-by: Adam Korczynski <[email protected]> * change 'pinned' to 'unpinned' in test name Signed-off-by: Adam Korczynski <[email protected]> * export 'depTypeKey' Signed-off-by: Adam Korczynski <[email protected]> * Do not copy test Dockerfile Signed-off-by: Adam Korczynski <[email protected]> * rename test Signed-off-by: Adam Korczynski <[email protected]> * Rebase and bring back 'Test_generateOwnerToDisplay' Signed-off-by: Adam Korczynski <[email protected]> * Use API to create finding Signed-off-by: AdamKorcz <[email protected]> * one more change to how the probe creates a finding Signed-off-by: AdamKorcz <[email protected]> --------- Signed-off-by: Adam Korczynski <[email protected]> Signed-off-by: AdamKorcz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
Currently, the Pinned Dependencies check does not include probes.
What is the new behavior (if this is a feature change)?**
This converts the Pinned Dependencies evaluation to probes.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?