Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add some more projects to be scanned in the cron #3764

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

katzj
Copy link
Contributor

@katzj katzj commented Jan 2, 2024

What kind of change does this PR introduce?

Infrastructure

What is the current behavior?

What is the new behavior (if this is a feature change)?**

This adds projects to the weekly cron job

  • [N/A] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

@katzj katzj requested a review from a team as a code owner January 2, 2024 22:34
@katzj katzj requested review from naveensrinivasan and spencerschrock and removed request for a team January 2, 2024 22:34
@katzj katzj temporarily deployed to integration-test January 2, 2024 22:34 — with GitHub Actions Inactive
@katzj katzj changed the title Add some more projects to be scanned in the cron 🌱 🌱 Add some more projects to be scanned in the cron Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Merging #3764 (baf917d) into main (fdf3fb2) will decrease coverage by 5.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3764      +/-   ##
==========================================
- Coverage   75.34%   70.33%   -5.01%     
==========================================
  Files         229      229              
  Lines       15502    15502              
==========================================
- Hits        11680    10904     -776     
- Misses       3099     3928     +829     
+ Partials      723      670      -53     

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #3732, i'm going to temporarily hold this. We should have the quota for both, but I still want to control when. It's on my list of things to look at this week

@spencerschrock
Copy link
Member

Merging #3732 created some conflicts (we dont normally have two PRs touching these files open), but should be ready to go afterwards.

@katzj
Copy link
Contributor Author

katzj commented Jan 8, 2024

Rebased my branch 👍 ✅

@katzj katzj requested a review from spencerschrock January 8, 2024 21:00
@katzj katzj temporarily deployed to integration-test January 8, 2024 21:00 — with GitHub Actions Inactive
@spencerschrock
Copy link
Member

can you run make add-projects and commit the changes? I'm seeing duplicates.
e.g. "github.com/gitlabphp/client," vs "github.com/GitLabPHP/Client" which is already in the list

For the future: I'll add this to the documentation somewhere and make the CI fail if it's not done.

@katzj
Copy link
Contributor Author

katzj commented Jan 9, 2024

Done ✅

@katzj katzj temporarily deployed to integration-test January 9, 2024 02:38 — with GitHub Actions Inactive
@spencerschrock spencerschrock merged commit 45425b6 into ossf:main Jan 9, 2024
38 checks passed
@spencerschrock
Copy link
Member

Thanks @katzj sorry for the back and forth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants