Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update stale workflow to exempt Structured Results milestone #3634

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

afmarcum
Copy link
Contributor

@afmarcum afmarcum commented Oct 31, 2023

What kind of change does this PR introduce?

Exempts Structured Results issues from being labeled stale

What is the current behavior?

Exemptions are based on labels only and it is not immediately clear which labels are exempt.

What is the new behavior (if this is a feature change)?**

Contributors can apply Structured Results milestone rather than having to remember labels for exemption.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


@afmarcum afmarcum requested a review from a team as a code owner October 31, 2023 18:56
@afmarcum afmarcum requested review from spencerschrock and laurentsimon and removed request for a team October 31, 2023 18:56
@afmarcum afmarcum temporarily deployed to gitlab October 31, 2023 18:56 — with GitHub Actions Inactive
@afmarcum afmarcum temporarily deployed to integration-test October 31, 2023 18:56 — with GitHub Actions Inactive
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #3634 (2b4ac07) into main (478f347) will decrease coverage by 5.88%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3634      +/-   ##
==========================================
- Coverage   76.09%   70.22%   -5.88%     
==========================================
  Files         199      199              
  Lines       13741    13741              
==========================================
- Hits        10456     9649     -807     
- Misses       2674     3532     +858     
+ Partials      611      560      -51     

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exempting the milestone is good, just please address the duplicated line.

.github/workflows/stale.yml Outdated Show resolved Hide resolved
@afmarcum afmarcum temporarily deployed to gitlab November 1, 2023 16:49 — with GitHub Actions Inactive
@afmarcum afmarcum temporarily deployed to integration-test November 1, 2023 16:50 — with GitHub Actions Inactive
@spencerschrock spencerschrock merged commit c52a170 into main Nov 1, 2023
38 checks passed
@spencerschrock spencerschrock deleted the update-workflow-stale branch November 1, 2023 17:02
diogoteles08 pushed a commit to diogoteles08/scorecard that referenced this pull request Nov 13, 2023
…3634)

* 🌱 Update stale workflow to exempt Structured Results milestone

* Removed duplicate line, updated stale-pr-message, and removed custom stale labels

Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
…3634)

* 🌱 Update stale workflow to exempt Structured Results milestone

* Removed duplicate line, updated stale-pr-message, and removed custom stale labels

Signed-off-by: Allen Shearin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants