🌱 Run fieldalignment on ./checker, ./checks and ./finding #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
Signed-off-by: AdamKorcz <[email protected]>
AdamKorcz
force-pushed
the
fix-fieldalignment
branch
from
b483645 to
e0f2d01
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
==========================================
- Coverage 65.26% 60.37% -4.90%
==========================================
Files 194 182 -12
Lines 13490 12668 -822
==========================================
- Hits 8804 7648 -1156
- Misses 4214 4570 +356
+ Partials 472 450 -22 |
Comment on lines
+28
to
+46
| Metadata MetadataData | ||
| BranchProtectionResults BranchProtectionsData | ||
| CIIBestPracticesResults CIIBestPracticesData | ||
| CITestResults CITestData | ||
| FuzzingResults FuzzingData | ||
| SignedReleasesResults SignedReleasesData | ||
| CodeReviewResults CodeReviewData | ||
| ContributorsResults ContributorsData | ||
| DangerousWorkflowResults DangerousWorkflowData | ||
| WebhookResults WebhooksData | ||
| DependencyUpdateToolResults DependencyUpdateToolData | ||
| FuzzingResults FuzzingData | ||
| BinaryArtifactResults BinaryArtifactData | ||
| LicenseResults LicenseData | ||
| MaintainedResults MaintainedData | ||
| Metadata MetadataData | ||
| VulnerabilitiesResults VulnerabilitiesData | ||
| CITestResults CITestData | ||
| PackagingResults PackagingData | ||
| PinningDependenciesResults PinningDependenciesData | ||
| SecurityPolicyResults SecurityPolicyData | ||
| SignedReleasesResults SignedReleasesData | ||
| MaintainedResults MaintainedData | ||
| TokenPermissionsResults TokenPermissionsData | ||
| VulnerabilitiesResults VulnerabilitiesData | ||
| WebhookResults WebhooksData | ||
| DangerousWorkflowResults DangerousWorkflowData | ||
| CIIBestPracticesResults CIIBestPracticesData |
There was a problem hiding this comment.
Doesn't this reverse #3540 ?
Can we talk about what you're seeing with make check-linter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR runs fieldalignment on
./checker,./checks,./findingand./pkg.fieldAlignmentcomplains in makecheck-linter, but runningfieldAlignmentalso removes comments, so I am not quite sure about it.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)