-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add E2E test for Gitlab repo webhooks #3346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensrinivasan
requested review from
justaugustus,
laurentsimon,
spencerschrock and
raghavkaul
as code owners
August 3, 2023 20:02
naveensrinivasan
had a problem deploying
to
gitlab
August 3, 2023 20:02 — with
GitHub Actions
Failure
naveensrinivasan
had a problem deploying
to
integration-test
August 3, 2023 20:02 — with
GitHub Actions
Failure
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3346 +/- ##
=======================================
Coverage 61.88% 61.88%
=======================================
Files 178 178
Lines 12862 12862
=======================================
Hits 7960 7960
Misses 4462 4462
Partials 440 440 |
naveensrinivasan
commented
Aug 4, 2023
naveensrinivasan
temporarily deployed
to
integration-test
August 4, 2023 21:50 — with
GitHub Actions
Inactive
naveensrinivasan
force-pushed
the
naveen/e2e/clients/gitlabrepo/webhooks
branch
from
August 4, 2023 21:56
898f1d1
to
0562a3b
Compare
naveensrinivasan
temporarily deployed
to
integration-test
August 4, 2023 21:56 — with
GitHub Actions
Inactive
raghavkaul
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
- List the webhooks and check that there is at least one returned Signed-off-by: naveensrinivasan <[email protected]>
- Add a skipIfTokenIsNot check for GitLab - Update the MakeGitlabRepo function to use a new URL [clients/gitlabrepo/workflow_e2e_test.go] - Add a skipIfTokenIsNot check for GitLab - Update the MakeGitlabRepo function to use a new URL Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
force-pushed
the
naveen/e2e/clients/gitlabrepo/webhooks
branch
from
August 7, 2023 17:55
0562a3b
to
654f40b
Compare
naveensrinivasan
temporarily deployed
to
integration-test
August 7, 2023 17:56 — with
GitHub Actions
Inactive
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* 🌱 Add E2E test for Gitlab repo webhooks - List the webhooks and check that there is at least one returned Signed-off-by: naveensrinivasan <[email protected]> * Update GitLab repo workflow for e2e tests - Add a skipIfTokenIsNot check for GitLab - Update the MakeGitlabRepo function to use a new URL [clients/gitlabrepo/workflow_e2e_test.go] - Add a skipIfTokenIsNot check for GitLab - Update the MakeGitlabRepo function to use a new URL Signed-off-by: naveensrinivasan <[email protected]> --------- Signed-off-by: naveensrinivasan <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)