✨ scdiff: normalize scorecard results #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
raghavkaul
as code owners
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3294 +/- ##
==========================================
- Coverage 72.83% 66.21% -6.63%
==========================================
Files 173 173
Lines 12700 12703 +3
==========================================
- Hits 9250 8411 -839
- Misses 2944 3824 +880
+ Partials 506 468 -38 |
It's a cobra command, which runs scorecard on a repo URI. This would be difficult to do as written. The diff coverage in this PR is already 80% Edit: Misread your message slightly. Can try to get the error lines covered in |
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Covered an additional line in Please take another look @naveensrinivasan |
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
naveensrinivasan
force-pushed
the
golden/generate-format
branch
from
4c87f13 to
0a863f0
Compare
naveensrinivasan
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* Normalize results. Signed-off-by: Spencer Schrock <[email protected]> * add tests for standardized output format Signed-off-by: Spencer Schrock <[email protected]> * move comment to proper place. Signed-off-by: Spencer Schrock <[email protected]> * add comment about pretty print. Signed-off-by: Spencer Schrock <[email protected]> * format test can be parallel. Signed-off-by: Spencer Schrock <[email protected]> * Add normalize nil test. Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
scorecard results were printed verbatim by the scdiff tool
What is the new behavior (if this is a feature change)?**
certain fields, such as dates or commit shas, are stripped before printing.
these fields are informational, but don't provide value in detecting a change in scorecard behavior. instead they interfere with the comparison
Which issue(s) this PR fixes
Related to #2462, 2/n
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)