🌱 Gitlab: Move tests that connect to gitlab.com out of unit-tests #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
spencerschrock
as code owners
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3221 +/- ##
==========================================
+ Coverage 62.93% 64.97% +2.03%
==========================================
Files 168 168
Lines 12600 12600
==========================================
+ Hits 7930 8187 +257
+ Misses 4238 3959 -279
- Partials 432 454 +22 |
naveensrinivasan
approved these changes
Jun 27, 2023
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
Signed-off-by: Raghav Kaul <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
…sf#3221) * Move tests that connect to GitLab out of e2e Signed-off-by: Raghav Kaul <[email protected]> * update Signed-off-by: Raghav Kaul <[email protected]> * mark as pat test Signed-off-by: Raghav Kaul <[email protected]> --------- Signed-off-by: Raghav Kaul <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Moves tests that connect to GitLab instances out of the unit test framework and into E2E. Unit tests should not connect to the network.