🌱 Added unit tests for rpc #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensrinivasan
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
spencerschrock and
raghavkaul
as code owners
naveensrinivasan
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
==========================================
+ Coverage 62.82% 62.93% +0.11%
==========================================
Files 168 168
Lines 12600 12600
==========================================
+ Hits 7916 7930 +14
+ Misses 4252 4238 -14
Partials 432 432 |
raghavkaul
approved these changes
Jun 26, 2023
- Add a mockTokenAccessor and TokenOverRPC wrapper for testing - Add tests for TokenOverRPC.Next and TokenOverRPC.Release [clients/githubrepo/roundtripper/tokens/rpc_test.go] - Add a mockTokenAccessor for testing - Add a TokenOverRPC wrapper - Add a Next method to TokenOverRPC - Add a Release method to TokenOverRPC - Add a test for TokenOverRPC.Next - Add a test for TokenOverRPC.Release Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
force-pushed
the
naveen/unit-tests/rpc
branch
from
fc99e1f
to
6449e11
Compare
naveensrinivasan
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
- Add a mockTokenAccessor and TokenOverRPC wrapper for testing - Add tests for TokenOverRPC.Next and TokenOverRPC.Release [clients/githubrepo/roundtripper/tokens/rpc_test.go] - Add a mockTokenAccessor for testing - Add a TokenOverRPC wrapper - Add a Next method to TokenOverRPC - Add a Release method to TokenOverRPC - Add a test for TokenOverRPC.Next - Add a test for TokenOverRPC.Release Signed-off-by: naveensrinivasan <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)