Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Ignore deprecation warning for dependencydiff tests. #3136

Merged
merged 1 commit into from
Jun 7, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions e2e/dependencydiff_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
. "github.com/onsi/gomega"

"github.com/ossf/scorecard/v4/checks"
//nolint:staticcheck // we know it's deprecated and the tests will be removed when the package is
"github.com/ossf/scorecard/v4/dependencydiff"
)

Expand All @@ -40,6 +41,7 @@ var _ = Describe("E2E TEST:"+dependencydiff.Depdiff, func() {
changeTypesToCheck := []string{
"removed", // Only checking those removed ones will make this test faster.
}
//nolint:staticcheck // we know it's deprecated and the tests will be removed when the package is
results, err := dependencydiff.GetDependencyDiffResults(
ctx,
repoURI,
Expand All @@ -58,6 +60,7 @@ var _ = Describe("E2E TEST:"+dependencydiff.Depdiff, func() {
changeTypesToCheck := []string{
"removed",
}
//nolint:staticcheck // we know it's deprecated and the tests will be removed when the package is
results, err := dependencydiff.GetDependencyDiffResults(
ctx,
repoURI,
Expand All @@ -76,6 +79,7 @@ var _ = Describe("E2E TEST:"+dependencydiff.Depdiff, func() {
changeTypesToCheck := []string{
"removed",
}
//nolint:staticcheck // we know it's deprecated and the tests will be removed when the package is
_, err := dependencydiff.GetDependencyDiffResults(
ctx,
repoURI,
Expand Down