Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump golang.org/x/tools from 0.8.0 to 0.9.0 #2976

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 9, 2023

Bumps golang.org/x/tools from 0.8.0 to 0.9.0.

Release notes

Sourced from golang.org/x/tools's releases.

[email protected]

This release contains significant performance improvements (especially in incremental processing after source changes), bug fixes, and support for the LSP “inlay hints” feature, along with several other minor enhancements.

Performance improvements

Source edits cause gopls to invalidate and recompute information about the workspace, most of which has not changed. Previously, gopls would spend significant CPU copying data structures, sometimes more than 100ms per keystroke in a large workspace. This release includes many optimizations to avoid copying data needlessly, including a new map representation to achieve copying in constant time. Special thanks to @​euroelessar for the design and implementation of this data structure.

As a result of these improvements, gopls should be more responsive while typing in large codebases, though it will still use a lot of memory.

Time to process a change notification in the Kubernetes repo: image

New Features

Inlay hints

Added support for displaying inlay hints of composite literal field names and types, constant values, function parameter names, function type params, and short variable declarations. You can try these out in the vscode-go nightly by enabling inlay hints settings.

image3

Package References

Find references on package foo now lists locations where the given package is imported.

Quick-fix to add field names to struct literals

A new quick fix adds field names to struct literals with unkeyed fields.

image1

Bug fixes

This release includes the following notable bugfixes:

  • Fixes for goimports performance and correctness when using a go.work file (#52784)
  • Fix a crash during renaming in a package that uses generics (#52940)
  • Fix gopls getting confused when moving a file from the foo_test package to foo package (#45317)

A full list of all issues fixed can be found in the gopls/v0.9.0 milestone. To report a new problem, please file a new issue at https://go.dev/issues/new.

Thank you to our contributors!

Thank you for your contribution, @​alandonovan, @​euroelessar, @​findleyr, @​hyangah, @​jamalc, @​jba, @​marwan-at-work, @​suzmue, and @​dle8!

What’s Next?

The next planned gopls release is v0.9.1. We’re excited about features and improvements on the horizon, for example:

  • Improved startup performance
  • More accurate static analysis from fully analyzing packages outside of the workspace

... (truncated)

Commits
  • 0809ec2 gopls/internal/lsp/source: document {All,Workspace}Metadata
  • 8f7fb01 go/analysis/unitchecker: add test of go vet on std
  • 23e52a3 bisect: diagnose bad targets better
  • d5af889 gopls: set GOWORK=off for loads from debug and safetoken tests
  • c93329a go/analysis/passes/printf: reshorten diagnostic about %s in Println call
  • 6219726 go.mod: update golang.org/x dependencies
  • f4d143e go/ssa: cleanup TestGenericBodies to pickup package name
  • 3d99ebe gopls/diff/unified: remove redundant information
  • 479f5c6 go/ssa: Origin is only available after building
  • 6d1dd12 go/analysis: simplify unusedresult
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.8.0...v0.9.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 9, 2023
@dependabot dependabot bot temporarily deployed to integration-test May 9, 2023 08:59 Inactive
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #2976 (c1b1e7d) into main (bc615e3) will increase coverage by 1.70%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2976      +/-   ##
==========================================
+ Coverage   53.01%   54.72%   +1.70%     
==========================================
  Files         161      161              
  Lines       12303    12303              
==========================================
+ Hits         6523     6733     +210     
+ Misses       5404     5184     -220     
- Partials      376      386      +10     

@naveensrinivasan naveensrinivasan merged commit d7229e0 into main May 9, 2023
@naveensrinivasan naveensrinivasan deleted the dependabot/go_modules/golang.org/x/tools-0.9.0 branch May 9, 2023 14:02
gabibguti pushed a commit to gabibguti/scorecard that referenced this pull request May 10, 2023
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.8.0...v0.9.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
balteravishay pushed a commit to balteravishay/scorecard that referenced this pull request May 29, 2023
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.8.0...v0.9.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Avishay <[email protected]>
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.8.0...v0.9.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Allen Shearin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant