Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Unit Tests for checker/client #2851

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

naveensrinivasan
Copy link
Member

  • Included the unit tests for checker/client.go
  • Coverage to 87%

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


@naveensrinivasan naveensrinivasan self-assigned this Apr 11, 2023
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test April 11, 2023 19:02 — with GitHub Actions Inactive
@naveensrinivasan naveensrinivasan force-pushed the naveen/feat/unit-tests-checker-client branch from 1420c04 to 30bdaa8 Compare April 11, 2023 19:03
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test April 11, 2023 19:03 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #2851 (a54cada) into main (f3c480f) will increase coverage by 0.63%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
+ Coverage   49.81%   50.45%   +0.63%     
==========================================
  Files         158      158              
  Lines       11992    11992              
==========================================
+ Hits         5974     6050      +76     
+ Misses       5648     5569      -79     
- Partials      370      373       +3     

@naveensrinivasan naveensrinivasan enabled auto-merge (squash) April 11, 2023 19:55
checker/client_test.go Outdated Show resolved Hide resolved
checker/client_test.go Outdated Show resolved Hide resolved
- Included the unit tests for checker/client.go
- Coverage to 87%

Signed-off-by: naveensrinivasan <[email protected]>
Signed-off-by: naveensrinivasan <[email protected]>
@naveensrinivasan naveensrinivasan force-pushed the naveen/feat/unit-tests-checker-client branch from 30bdaa8 to a54cada Compare April 13, 2023 19:32
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test April 13, 2023 19:32 — with GitHub Actions Inactive
@naveensrinivasan naveensrinivasan merged commit fd78f95 into main Apr 13, 2023
@naveensrinivasan naveensrinivasan deleted the naveen/feat/unit-tests-checker-client branch April 13, 2023 19:44
balteravishay pushed a commit to balteravishay/scorecard that referenced this pull request Apr 14, 2023
- Included the unit tests for checker/client.go
- Coverage to 87%

Signed-off-by: naveensrinivasan <[email protected]>
Signed-off-by: Avishay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants