-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add correct contact to CODE_OF_CONDUCT.md #2508
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
=======================================
Coverage 40.40% 40.40%
=======================================
Files 122 122
Lines 9908 9908
=======================================
Hits 4003 4003
Misses 5624 5624
Partials 281 281 |
Integration tests success for |
Stale pull request message |
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Thanks for this, LGTM & approval.
Signed-off-by: Caleb Brown <[email protected]>
98682e2
to
bd7f06f
Compare
Integration tests success for |
Integration tests success for |
The CI will never succeed for this, we'll need to fix the workflow: |
There doesn't seem to be any native way of fixing the skipped checks, for reasons that this blog sums up well. |
I've not read the link, but I think you can declare an additional job that depends on the skipped, and mark the new job |
I think this is a little different. The jobs are never scheduled due to the path filtering at the top. I don't think |
Stale pull request message |
Integration tests success for |
Integration tests success for |
Signed-off-by: Caleb Brown <[email protected]> Signed-off-by: Caleb Brown <[email protected]> Co-authored-by: Azeem Shaikh <[email protected]>
Signed-off-by: Caleb Brown <[email protected]> Signed-off-by: Caleb Brown <[email protected]> Co-authored-by: Azeem Shaikh <[email protected]>
Signed-off-by: Caleb Brown [email protected]
What kind of change does this PR introduce?
Docs Update
What is the current behavior?
[INSERT CONTACT METHOD]
is in the code of conduct.What is the new behavior (if this is a feature change)?**
Replace
[INSERT CONTACT METHOD]
with actual contact [email protected] (as verified in Slack).Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)