🐛 Fix .lib false positives in binary artifacts

[laurentsimon]

Fix .lib false positives in binary artifacts
no breaking changes

Fix .lib false positives in binary artifacts

closes #1868

[codecov]

Codecov Report

Merging #1879 (4bb8c93) into main (2cb6541) will increase coverage by 3.05%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
+ Coverage   51.42%   54.47%   +3.05%     
==========================================
  Files          79       79              
  Lines        6693     6709      +16     
==========================================
+ Hits         3442     3655     +213     
+ Misses       3024     2820     -204     
- Partials      227      234       +7     

[naveensrinivasan]

Thanks!

[github-actions]

Integration tests success for
[98dbc29]
(https://github.com/ossf/scorecard/actions/runs/2265020234)

[github-actions]

Integration tests success for
[ef246fc]
(https://github.com/ossf/scorecard/actions/runs/2265028847)

[azeemshaikh38]

Let's do the sanity test iff exists1 == false. I would trust the magic number inference more than the character search logic we have here and we can fallback to it if the magic number inference fails.

if exists1 {
  // Binary file
}

if !isText(content) && exists2 {
  // Binary file
}

As a follow up, we could consider using common parsers (like Makefile, YAML, JSON etc.) to check whether the file has text content. Basically, if any parsers are able to successfully parse the file we can safely infer that the file is text only.

[laurentsimon]

Let's do the sanity test iff exists1 == false. I would trust the magic number inference more than the character search logic we have here and we can fallback to it if the magic number inference fails.

if exists1 {
  // Binary file
}

if !isText(content) && exists2 {
  // Binary file
}

done.

[github-actions]

Integration tests success for
[4bb8c93]
(https://github.com/ossf/scorecard/actions/runs/2265963886)

[azeemshaikh38]

Thanks!