Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add token needed for checks in README #1854

Merged
merged 3 commits into from
Apr 26, 2022
Merged

✨ Add token needed for checks in README #1854

merged 3 commits into from
Apr 26, 2022

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Apr 21, 2022 •
edited
Loading

Add token needed for checks in README
No breaking changes

Add token needed for checks in README

@laurentsimon laurentsimon requested a review from olivekl as a code owner April 21, 2022 23:51
@laurentsimon laurentsimon temporarily deployed to integration-test April 21, 2022 23:52 Inactive
@codecov
Copy link

codecov bot commented Apr 21, 2022 •
edited
Loading

Codecov Report

Merging #1854 (0ef9ec4) into main (ac88460) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1854   +/-   ##
=======================================
  Coverage   51.80%   51.80%           
=======================================
  Files          79       79           
  Lines        6899     6899           
=======================================
  Hits         3574     3574           
  Misses       3080     3080           
  Partials      245      245

@laurentsimon laurentsimon changed the title ✨ Add Token permissions to README check ✨ Add token needed for checks in README Apr 22, 2022
@github-actions
Copy link

Integration tests success for
[8c65843]
(https://github.com/ossf/scorecard/actions/runs/2204948530)

@laurentsimon
Copy link
Contributor Author

friendly ping

@laurentsimon laurentsimon temporarily deployed to integration-test April 22, 2022 19:41 Inactive
@github-actions
Copy link

Integration tests success for
[578235b]
(https://github.com/ossf/scorecard/actions/runs/2209710865)

@laurentsimon
Copy link
Contributor Author

friendly ping for reviews

@laurentsimon laurentsimon temporarily deployed to integration-test April 26, 2022 15:22 Inactive
@laurentsimon laurentsimon enabled auto-merge (squash) April 26, 2022 15:36
olivekl
olivekl suggested changes Apr 26, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@laurentsimon laurentsimon temporarily deployed to integration-test April 26, 2022 15:37 Inactive
olivekl
olivekl approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@olivekl olivekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about adding a link to the Token/Auth section if possible; otherwise LGTM.

@github-actions
Copy link

Integration tests success for
[0856d7f]
(https://github.com/ossf/scorecard/actions/runs/2227635366)

@github-actions
Copy link

Integration tests success for
[0ef9ec4]
(https://github.com/ossf/scorecard/actions/runs/2227750968)

@laurentsimon laurentsimon merged commit b304306 into ossf:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivekl olivekl olivekl approved these changes

@azeemshaikh38 azeemshaikh38 Awaiting requested review from azeemshaikh38

@naveensrinivasan naveensrinivasan Awaiting requested review from naveensrinivasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentsimon @olivekl