⚠️ Removing the error field from CheckResult struct
#1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensrinivasan
requested review from
azeemshaikh38,
justaugustus and
laurentsimon
as code owners
naveensrinivasan
force-pushed
the
naveen/feat/remove-error
branch
from
5cb7f63 to
a9dab73
Compare
|
Note: you could rename |
naveensrinivasan
force-pushed
the
naveen/feat/remove-error
branch
from
a9dab73 to
720be15
Compare
- Removing the error field from result - #1393 Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
force-pushed
the
naveen/feat/remove-error
branch
from
720be15 to
8a98ab9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1853 +/- ##
==========================================
+ Coverage 52.13% 55.13% +3.00%
==========================================
Files 77 77
Lines 6823 6823
==========================================
+ Hits 3557 3762 +205
+ Misses 3023 2812 -211
- Partials 243 249 +6 |
|
Integration tests success for |
|
Integration tests success for |
naveensrinivasan
added a commit
that referenced
this pull request
Apr 22, 2022
- Removing the pass field from result
- #1393
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
added a commit
that referenced
this pull request
May 2, 2022
- Removing the pass field from result
- #1393
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
added a commit
that referenced
this pull request
May 2, 2022
- Removing the pass field from result
- #1393
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
added a commit
that referenced
this pull request
May 2, 2022
- Removing the pass field from result
- #1393
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
added a commit
that referenced
this pull request
May 3, 2022
- Removing the pass field from result
- #1393
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
added a commit
that referenced
this pull request
May 3, 2022
- Removing the pass field from result
- #1393
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
added a commit
that referenced
this pull request
May 3, 2022
- Removing the pass field from result
- #1393
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
added a commit
that referenced
this pull request
May 3, 2022
- Removing the pass field from result
- #1393
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
added a commit
that referenced
this pull request
May 3, 2022
- Removing the pass field from result
- #1393
Signed-off-by: naveensrinivasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckResultSigned-off-by: naveensrinivasan [email protected]
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)