Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Raw results for dangerous workflow #1849

Merged
merged 8 commits into from
Apr 21, 2022
Merged

✨ Raw results for dangerous workflow #1849

merged 8 commits into from
Apr 21, 2022

Conversation

laurentsimon
Copy link
Contributor

Raw results for dangerous workflow
no breaking changes

Note: need to finalize the unit tests

Raw results for dangerous workflow

@laurentsimon laurentsimon temporarily deployed to integration-test April 19, 2022 16:56 Inactive
@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #1849 (2c72f6c) into main (72e2486) will decrease coverage by 0.77%.
The diff coverage is 54.35%.

@@            Coverage Diff             @@
##             main    #1849      +/-   ##
==========================================
- Coverage   52.90%   52.13%   -0.78%     
==========================================
  Files          75       77       +2     
  Lines        6733     6823      +90     
==========================================
- Hits         3562     3557       -5     
- Misses       2926     3023      +97     
+ Partials      245      243       -2

@github-actions
Copy link

Integration tests success for
[89c8efe]
(https://github.com/ossf/scorecard/actions/runs/2191014139)

@laurentsimon
Copy link
Contributor Author

friendly ping

@laurentsimon laurentsimon temporarily deployed to integration-test April 21, 2022 15:35 Inactive
@github-actions
Copy link

Integration tests success for
[9349ce6]
(https://github.com/ossf/scorecard/actions/runs/2202825943)

azeemshaikh38
azeemshaikh38 approved these changes Apr 21, 2022
View reviewed changes
checks/raw/dangerous_workflow.go Outdated Show resolved Hide resolved
checker/raw_result.go Outdated Show resolved Hide resolved
checks/evaluation/dangerous_workflow.go Outdated Show resolved Hide resolved
@laurentsimon laurentsimon temporarily deployed to integration-test April 21, 2022 21:13 Inactive
@laurentsimon laurentsimon enabled auto-merge (squash) April 21, 2022 21:16
@laurentsimon laurentsimon temporarily deployed to integration-test April 21, 2022 21:16 Inactive
@github-actions
Copy link

Integration tests success for
[fe73d77]
(https://github.com/ossf/scorecard/actions/runs/2204373268)

@github-actions
Copy link

Integration tests success for
[6035589]
(https://github.com/ossf/scorecard/actions/runs/2204384439)

@laurentsimon
Copy link
Contributor Author

temporarily disabling build-proto pre-submit to merge, because it's failing on protbuf

@laurentsimon laurentsimon disabled auto-merge April 21, 2022 21:44
@laurentsimon laurentsimon enabled auto-merge (squash) April 21, 2022 21:44
@laurentsimon laurentsimon temporarily deployed to integration-test April 21, 2022 21:45 Inactive
@laurentsimon laurentsimon mentioned this pull request Apr 21, 2022
Closed
@github-actions
Copy link

Integration tests success for
[2c72f6c]
(https://github.com/ossf/scorecard/actions/runs/2204499536)

@laurentsimon laurentsimon merged commit 4622952 into ossf:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@naveensrinivasan naveensrinivasan Awaiting requested review from naveensrinivasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentsimon @azeemshaikh38