Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix e2e branch #1835

Merged
merged 1 commit into from
Apr 13, 2022
Merged

🐛 Fix e2e branch #1835

merged 1 commit into from
Apr 13, 2022

Conversation

laurentsimon
Copy link
Contributor

See #1834

no breaking changes.

Fix e2e branch

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1835 (1a6fe83) into main (eedd16d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1835   +/-   ##
=======================================
  Coverage   53.51%   53.51%           
=======================================
  Files          73       73           
  Lines        6692     6692           
=======================================
  Hits         3581     3581           
  Misses       2865     2865           
  Partials      246      246           

@laurentsimon
Copy link
Contributor Author

WARNING: I've disabled the trusted integration tests pre-submit to be able to merge this one (since it fixes it).
However, protobuf is still failing.
@azeemsgoogle do you mind if I we disable these checks that fail on protobuf to merge at least this PR? I can create an issue trackig which checks we've disabled and need to be re-enabled

@azeemshaikh38
Copy link
Contributor

WARNING: I've disabled the trusted integration tests pre-submit to be able to merge this one (since it fixes it). However, protobuf is still failing. @azeemsgoogle do you mind if I we disable these checks that fail on protobuf to merge at least this PR? I can create an issue trackig which checks we've disabled and need to be re-enabled

Sure, sg. I haven't found the time to investigate further into the proto failures. can disable for now.

@laurentsimon laurentsimon merged commit 9120285 into ossf:main Apr 13, 2022
@laurentsimon
Copy link
Contributor Author

WARNING: I've disabled the trusted integration tests pre-submit to be able to merge this one (since it fixes it). However, protobuf is still failing. @azeemsgoogle do you mind if I we disable these checks that fail on protobuf to merge at least this PR? I can create an issue trackig which checks we've disabled and need to be re-enabled

Sure, sg. I haven't found the time to investigate further into the proto failures. can disable for now.

Did you disable them? I see most of the checks passed this time. Just want to make sure I know which to re-enable :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants